Adds bugfix for lwip multicast group commands #20133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agnostics_impl' into bugfix/lwip-group-multicast
| @@ -133,7 +133,7 @@ CHIP_ERROR UDPEndPointImplLwIP::LwIPBindInterface(struct udp_pcb * aUDP, Interfa | |||
| InterfaceId UDPEndPointImplLwIP::GetBoundInterface() const | |||
| { | |||
| #if HAVE_LWIP_UDP_BIND_NETIF | |||
| return InterfaceId(netif_get_by_index(mUDP->netif_idx)); | |||
| return InterfaceId(netif_get_by_index(mUDP->netif_idx + 1)); | |||
There was a problem hiding this comment.
Why "+ 1"?
The intent of the calling code is to do "all interfaces". Why is adding 1 here the right thing?
There was a problem hiding this comment.
mUDP->netif_idx is passing a value of 0, netif_get_by_index returns NULL in that case. Since there is a check for 0, ideally the right thing would be for the netif function to return the interface at 0 position.
There was a problem hiding this comment.
The point is, either that 0 is wrong to start with or we are misusing it if it's meant to mean "all interfaces"...
restyled-io
bot
deleted the branch
project-chip:restyled/feature/wifinetworkdiagnostics_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
netifbeing returned as null fromGetNetIfByInterface()which callsnetif_get_by_index()with index value0. The function returnsNULLif index0is passed as a reference to find thenetiffrom the list of netifs maintained by LwIP.Change overview
Adds fix for group commands based on UDP multicast.
Testing
No new unit test cases added, since this is part of TC-SC-5.1 and TC-SC-5.2.
Platforms tested:
RPI4 (chip-tool) + EFR32 + (rs9116/wf200)
Depends on #20124